-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP][14.0] l10n_it_ricevute_bancarie: small QoL improvements #4306
Conversation
aleuffre
commented
Jul 30, 2024
- Improve readability between fields "Payment Term" and "Bank"
- Stop invoice confirmation if bank is not set. Closes RiBa: conferma fatture senza conto bancario da list view #4304 for 14.0
- Fall back on commercial partner's bank if bank is not set for invoice's contact. Closes RiBa: utilizzare banca del partner commerciale in caso di indirizzo di fatturazione #4303 for 14.0
Adds a dash "-" between the name of the payment term and the name of the bank on the invoice, in case the payment term is a RiBa. Previously, the name of the payment term and the bank were contiguous, without even a space in between.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funzionale ok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funzionale OK
@OCA/local-italy-maintainers si può mergiare? sono fixes abbastanza ovvi. grazie! |
Riusciamo poi a passarla anche sulla 16? |
@MaurizioPellegrinet dopo il merge |
@OCA/local-italy-maintainers si può mergiare? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grazie della PR!
- Improve readability between fields "Payment Term" and "Bank"
Per questo manca la issue, la potresti creare? È una modifica piccola ma potrebbe comunque essere utile anche in 16.0
.
Per il resto mi sembra essere tutto ok; ho lasciato giusto qualche commento qui sotto ma secondo me nulla di bloccante per il merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ora non è chiarissimo quale sia il cambiamento nel onchange
, vedi il suggerimento in #4306 (comment)
or self.riba_partner_bank_id not in self.partner_id.bank_ids | ||
self.partner_id | ||
and self.move_type in ("out_invoice", "out_refund") | ||
and self.invoice_payment_term_id.riba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
si potrebbe usare is_riba_payment
che è relazionato
d9fbf20
to
e62fac0
Compare
Cannot confirm an invoice with C/O (RiBa) payment if the bank has not been set on the invoice.
If creating an invoice with C/O for a contact without a bank, fall back on the commercial partner's bank.
@francesco-ooops @SirAionTech Sulla 16.0 non è risolto il problema sollevato dalla issue #4303 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch
What a great day to merge this nice PR. Let's do it! |
@SirAionTech The merge process could not start, because command
|
This PR has the |
1 similar comment
This PR has the |
Congratulations, your PR was merged at 65953ea. Thanks a lot for contributing to OCA. ❤️ |